This PR removes the 'x-hack' from the artifact functions in the Armbian build framework. The 'x-hack' is a workaround used in bash scripts to avoid issues with empty variables in conditional statements. However, it is not a good practice and can be replaced with direct comparisons for better code readability and maintainability.
Summary of Changes
In lib/functions/artifacts/artifact-armbian-bsp-cli.sh, replaced all instances of the 'x-hack' with direct comparisons.
In lib/functions/artifacts/artifact-firmware.sh, replaced all instances of the 'x-hack' with direct comparisons.
In lib/functions/artifacts/artifacts-obtain.sh, replaced all instances of the 'x-hack' with direct comparisons.
In lib/functions/artifacts/artifacts-reversion.sh, replaced all instances of the 'x-hack' with direct comparisons.
In lib/functions/artifacts/artifact-uboot.sh, replaced all instances of the 'x-hack' with direct comparisons.
In lib/functions/artifacts/artifact-armbian-base-files.sh, replaced all instances of the 'x-hack' with direct comparisons.
In lib/functions/artifacts/artifact-rootfs.sh, replaced all instances of the 'x-hack' with direct comparisons.
In lib/functions/artifacts/artifact-kernel.sh, replaced all instances of the 'x-hack' with direct comparisons.
In lib/functions/artifacts/artifact-full_firmware.sh, replaced all instances of the 'x-hack' with direct comparisons.
Fixes #21.
🎉 Latest improvements to Sweep:
Getting Sweep to run linters before committing! Check out Sweep Sandbox Configs to set it up.
Added support for self-hosting! Check out Self-hosting Sweep to get started.
[Self Hosting] Multiple options to compute vector embeddings, configure your .env file using VECTOR_EMBEDDING_SOURCE
💡 To get Sweep to edit this pull request, you can:
Leave a comment below to get Sweep to edit the entire PR
Leave a comment in the code will only modify the file
Edit the original issue to get Sweep to recreate the PR from scratch
Description
This PR removes the 'x-hack' from the artifact functions in the Armbian build framework. The 'x-hack' is a workaround used in bash scripts to avoid issues with empty variables in conditional statements. However, it is not a good practice and can be replaced with direct comparisons for better code readability and maintainability.
Summary of Changes
lib/functions/artifacts/artifact-armbian-bsp-cli.sh, replaced all instances of the 'x-hack' with direct comparisons.lib/functions/artifacts/artifact-firmware.sh, replaced all instances of the 'x-hack' with direct comparisons.lib/functions/artifacts/artifacts-obtain.sh, replaced all instances of the 'x-hack' with direct comparisons.lib/functions/artifacts/artifacts-reversion.sh, replaced all instances of the 'x-hack' with direct comparisons.lib/functions/artifacts/artifact-uboot.sh, replaced all instances of the 'x-hack' with direct comparisons.lib/functions/artifacts/artifact-armbian-base-files.sh, replaced all instances of the 'x-hack' with direct comparisons.lib/functions/artifacts/artifact-rootfs.sh, replaced all instances of the 'x-hack' with direct comparisons.lib/functions/artifacts/artifact-kernel.sh, replaced all instances of the 'x-hack' with direct comparisons.lib/functions/artifacts/artifact-full_firmware.sh, replaced all instances of the 'x-hack' with direct comparisons.Fixes #21.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can: