kevinlu1248 / armbian-build

The Armbian Linux Build Framework under Kreyren's Management
GNU General Public License v2.0
0 stars 0 forks source link

Sweep: Remove x-hack from grub, nanopim4 and shellcheck scripts #42

Open sweep-nightly[bot] opened 1 year ago

sweep-nightly[bot] commented 1 year ago

Parent issue: #11

Checklist - [X] `packages/bsp/nanopim4/nanopim4-pwm-fan.sh` ✅ Commit [`a64e22e`](https://github.com/kevinlu1248/armbian-build/commit/a64e22ec2427d077e7f6ec86b94cb9ee494ddbe8)
• Replace all instances of 'x$var' with '$var'.
- [X] `packages/blobs/grub/09_linux_with_dtb.sh` ✅ Commit [`6f6a113`](https://github.com/kevinlu1248/armbian-build/commit/6f6a1139356d6b52a056fba57dee2a75283ec3a7)
• Replace all instances of 'x$var' with '$var'.
- [X] `lib/tools/shellcheck.sh` ❌ Failed
• Replace all instances of 'x$var' with '$var'.
sweep-nightly[bot] commented 1 year ago

Here's the PR! https://github.com/kevinlu1248/armbian-build/pull/47.

💎 Sweep Pro: I used GPT-4 to create this ticket. You have unlimited GPT-4 tickets.


Actions (click)


Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/kevinlu1248/armbian-build/blob/e13c915efd6b71179224c064bd1c07fbbcb8b81b/packages/bsp/nanopim4/nanopim4-pwm-fan.sh#L1-L487 https://github.com/kevinlu1248/armbian-build/blob/e13c915efd6b71179224c064bd1c07fbbcb8b81b/packages/blobs/grub/09_linux_with_dtb.sh#L1-L455 https://github.com/kevinlu1248/armbian-build/blob/e13c915efd6b71179224c064bd1c07fbbcb8b81b/lib/tools/shellcheck.sh#L1-L146

Step 2: ⌨️ Coding


Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/remove-x-hack_5.

.


🎉 Latest improvements to Sweep:


💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. Join Our Discord