This PR removes the outdated 'x-hack' from conditional checks in the specified scripts. The 'x-hack' was used to ensure compatibility across different shells and systems, but it is now considered obsolete. The 'x-hack' instances have been replaced with modern and reliable conditional checks, ensuring the logic remains the same.
Summary of Changes
In packages/bsp/nanopim4/nanopim4-pwm-fan.sh:
Replaced all instances of 'x-hack' in conditional checks with modern equivalent conditional checks.
Tested the script to ensure it still functions as expected after the modifications.
In packages/blobs/grub/09_linux_with_dtb.sh:
Replaced all instances of 'x-hack' in conditional checks with modern equivalent conditional checks.
Tested the script to ensure it still functions as expected after the modifications.
In lib/tools/shellcheck.sh:
Replaced all instances of 'x-hack' in conditional checks with modern equivalent conditional checks.
Tested the script to ensure it still functions as expected after the modifications.
These changes improve the codebase by removing outdated practices and ensuring compatibility with modern shell scripting languages.
Fixes #4.
🎉 Latest improvements to Sweep:
Getting Sweep to run linters before committing! Check out Sweep Sandbox Configs to set it up.
Added support for self-hosting! Check out Self-hosting Sweep to get started.
[Self Hosting] Multiple options to compute vector embeddings, configure your .env file using VECTOR_EMBEDDING_SOURCE
💡 To get Sweep to edit this pull request, you can:
Leave a comment below to get Sweep to edit the entire PR
Leave a comment in the code will only modify the file
Edit the original issue to get Sweep to recreate the PR from scratch
Description
This PR removes the outdated 'x-hack' from conditional checks in the specified scripts. The 'x-hack' was used to ensure compatibility across different shells and systems, but it is now considered obsolete. The 'x-hack' instances have been replaced with modern and reliable conditional checks, ensuring the logic remains the same.
Summary of Changes
In
packages/bsp/nanopim4/nanopim4-pwm-fan.sh:In
packages/blobs/grub/09_linux_with_dtb.sh:In
lib/tools/shellcheck.sh:These changes improve the codebase by removing outdated practices and ensuring compatibility with modern shell scripting languages.
Fixes #4.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can: