kevinlu1248 / armbian-build

The Armbian Linux Build Framework under Kreyren's Management
GNU General Public License v2.0
0 stars 0 forks source link

Sweep: Remove x-hack from grub and nanopim4 scripts #57

Open sweep-nightly[bot] opened 10 months ago

sweep-nightly[bot] commented 10 months ago

Parent issue: #11

Checklist - [X] `packages/blobs/grub/09_linux_with_dtb.sh` ✅ Commit [`0099a6c`](https://github.com/kevinlu1248/armbian-build/commit/0099a6c306238b068df41be67a22c30af8af2bd1)
• Replace all instances of the 'x-hack' in conditional statements with a more modern approach. For example, change '[ "x${GRUB_DEVICE_UUID}" = "x" ]' to '[ -z "${GRUB_DEVICE_UUID}" ]'. • Ensure that the new conditional statements are functionally equivalent to the old ones.
- [X] `packages/bsp/nanopim4/nanopim4-pwm-fan.sh` ❌ Failed
• Replace all instances of the 'x-hack' in conditional statements with a more modern approach. For example, change '[ "x${PWMCHIP}" = "x" ]' to '[ -z "${PWMCHIP}" ]'. • Ensure that the new conditional statements are functionally equivalent to the old ones.
sweep-nightly[bot] commented 10 months ago

Here's the PR! https://github.com/kevinlu1248/armbian-build/pull/60.

💎 Sweep Pro: I used GPT-4 to create this ticket. You have unlimited GPT-4 tickets.


Actions (click)


Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/kevinlu1248/armbian-build/blob/e13c915efd6b71179224c064bd1c07fbbcb8b81b/packages/bsp/nanopim4/nanopim4-pwm-fan.sh#L1-L487 https://github.com/kevinlu1248/armbian-build/blob/e13c915efd6b71179224c064bd1c07fbbcb8b81b/packages/blobs/grub/09_linux_with_dtb.sh#L1-L455

Step 2: ⌨️ Coding


Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/remove-x-hack_13.

.


🎉 Latest improvements to Sweep:


💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. Join Our Discord