This PR replaces all instances of the 'x-hack' in the nanopim4-pwm-fan.sh and 09_linux_with_dtb.sh scripts with the appropriate comparison operators. The 'x-hack' is used in bash and POSIX shell scripts for string comparison to avoid errors when one of the variables is empty or unset. However, it is not necessary if we ensure that the variables being compared are quoted correctly. The '==' operator is used for comparison in bash, and the '=' operator is used in POSIX shell.
Summary of Changes
In nanopim4-pwm-fan.sh, replaced all instances of the 'x-hack' with the '==' operator for comparison in bash. Ensured that the variables being compared are quoted correctly.
In 09_linux_with_dtb.sh, replaced all instances of the 'x-hack' with the '==' operator for comparison in bash. Ensured that the variables being compared are quoted correctly.
Fixes #65.
🎉 Latest improvements to Sweep:
Getting Sweep to run linters before committing! Check out Sweep Sandbox Configs to set it up.
Added support for self-hosting! Check out Self-hosting Sweep to get started.
[Self Hosting] Multiple options to compute vector embeddings, configure your .env file using VECTOR_EMBEDDING_SOURCE
💡 To get Sweep to edit this pull request, you can:
Leave a comment below to get Sweep to edit the entire PR
Leave a comment in the code will only modify the file
Edit the original issue to get Sweep to recreate the PR from scratch
Description
This PR replaces all instances of the 'x-hack' in the
nanopim4-pwm-fan.sh
and09_linux_with_dtb.sh
scripts with the appropriate comparison operators. The 'x-hack' is used in bash and POSIX shell scripts for string comparison to avoid errors when one of the variables is empty or unset. However, it is not necessary if we ensure that the variables being compared are quoted correctly. The '==' operator is used for comparison in bash, and the '=' operator is used in POSIX shell.Summary of Changes
nanopim4-pwm-fan.sh
, replaced all instances of the 'x-hack' with the '==' operator for comparison in bash. Ensured that the variables being compared are quoted correctly.09_linux_with_dtb.sh
, replaced all instances of the 'x-hack' with the '==' operator for comparison in bash. Ensured that the variables being compared are quoted correctly.Fixes #65.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can: