kevinlu1248 / armbian-build

The Armbian Linux Build Framework under Kreyren's Management
GNU General Public License v2.0
0 stars 0 forks source link

Sweep: Replace x-hack in grub and nanopim4 scripts #69

Open sweep-nightly[bot] opened 1 year ago

sweep-nightly[bot] commented 1 year ago

Parent issue: #11

Checklist - [X] `packages/blobs/grub/09_linux_with_dtb.sh` ✅ Commit [`d425620`](https://github.com/kevinlu1248/armbian-build/commit/d425620892a4718bf30feb3440b05b3b399e5c86)
• Replace all instances of 'x-hack' with the modern approach. For example, change `if [ "x${variable}" = "xvalue" ]` to `if [[ "${variable}" == "value" ]]` and `if [ "x${variable}" != "x" ]` to `if [[ -n "${variable}" ]]`.
- [X] `packages/bsp/nanopim4/nanopim4-pwm-fan.sh` ❌ Failed
• Replace all instances of 'x-hack' with the modern approach. For example, change `if [ "x${variable}" = "xvalue" ]` to `if [[ "${variable}" == "value" ]]` and `if [ "x${variable}" != "x" ]` to `if [[ -n "${variable}" ]]`.
sweep-nightly[bot] commented 1 year ago

Here's the PR! https://github.com/kevinlu1248/armbian-build/pull/72.

💎 Sweep Pro: I used GPT-4 to create this ticket. You have unlimited GPT-4 tickets.


Actions (click)


Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/kevinlu1248/armbian-build/blob/e13c915efd6b71179224c064bd1c07fbbcb8b81b/packages/bsp/nanopim4/nanopim4-pwm-fan.sh#L1-L487 https://github.com/kevinlu1248/armbian-build/blob/e13c915efd6b71179224c064bd1c07fbbcb8b81b/packages/blobs/grub/09_linux_with_dtb.sh#L1-L455 https://github.com/kevinlu1248/armbian-build/blob/e13c915efd6b71179224c064bd1c07fbbcb8b81b/lib/functions/image/initrd.sh#L1-L95 https://github.com/kevinlu1248/armbian-build/blob/e13c915efd6b71179224c064bd1c07fbbcb8b81b/lib/functions/host/host-utils.sh#L1-L95 https://github.com/kevinlu1248/armbian-build/blob/e13c915efd6b71179224c064bd1c07fbbcb8b81b/extensions/grub-with-dtb.sh#L1-L94

Step 2: ⌨️ Coding


Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/replace-x-hack_8.

.


🎉 Latest improvements to Sweep:


💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. Join Our Discord