This PR removes the outdated 'x-hack' shell scripting practice from the codebase. The 'x-hack' was used to ensure compatibility across different shells and systems, but it is now considered obsolete. The 'x-hack' has been replaced with a more modern and reliable approach in the specified files.
Summary of Changes
In packages/blobs/grub/09_linux_with_dtb.sh:
Replaced all instances of the 'x-hack' pattern '[ x$var = xval ]' with direct comparisons like '[ $var = val ]'.
In packages/bsp/nanopim4/nanopim4-pwm-fan.sh:
Replaced all instances of the 'x-hack' pattern '[ x$var = xval ]' with direct comparisons like '[ $var = val ]'.
In lib/tools/shellcheck.sh:
Replaced all instances of the 'x-hack' pattern '[ x$var = xval ]' with direct comparisons like '[ $var = val ]'.
These changes improve the readability and maintainability of the codebase by removing the outdated 'x-hack' practice.
Fixes #4.
🎉 Latest improvements to Sweep:
Getting Sweep to run linters before committing! Check out Sweep Sandbox Configs to set it up.
Added support for self-hosting! Check out Self-hosting Sweep to get started.
[Self Hosting] Multiple options to compute vector embeddings, configure your .env file using VECTOR_EMBEDDING_SOURCE
💡 To get Sweep to edit this pull request, you can:
Leave a comment below to get Sweep to edit the entire PR
Leave a comment in the code will only modify the file
Edit the original issue to get Sweep to recreate the PR from scratch
Description
This PR removes the outdated 'x-hack' shell scripting practice from the codebase. The 'x-hack' was used to ensure compatibility across different shells and systems, but it is now considered obsolete. The 'x-hack' has been replaced with a more modern and reliable approach in the specified files.
Summary of Changes
In
packages/blobs/grub/09_linux_with_dtb.sh:In
packages/bsp/nanopim4/nanopim4-pwm-fan.sh:In
lib/tools/shellcheck.sh:These changes improve the readability and maintainability of the codebase by removing the outdated 'x-hack' practice.
Fixes #4.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can: