This PR addresses the issue of 'x-hack' instances in the codebase by replacing them with more modern and reliable conditional checks. The 'x-hack' was a shell scripting practice used to ensure compatibility across different shells and systems, but it is now considered obsolete. The 'x-hack' instances were found in the following files:
packages/bsp/nanopim4/nanopim4-pwm-fan.sh
packages/blobs/grub/09_linux_with_dtb.sh
lib/tools/shellcheck.sh
Summary of Changes
In packages/bsp/nanopim4/nanopim4-pwm-fan.sh:
Replaced 'x-hack' instances with modern conditional checks.
Ensured that the logic of the script remains intact after the changes.
In packages/blobs/grub/09_linux_with_dtb.sh:
Replaced 'x-hack' instances with modern conditional checks.
Ensured that the logic of the script remains intact after the changes.
In lib/tools/shellcheck.sh:
Replaced 'x-hack' instances with modern conditional checks.
Ensured that the logic of the script remains intact after the changes.
These changes improve the codebase by removing the outdated 'x-hack' practice and replacing it with more reliable and modern conditional checks.
Fixes #4.
🎉 Latest improvements to Sweep:
Getting Sweep to run linters before committing! Check out Sweep Sandbox Configs to set it up.
Added support for self-hosting! Check out Self-hosting Sweep to get started.
[Self Hosting] Multiple options to compute vector embeddings, configure your .env file using VECTOR_EMBEDDING_SOURCE
💡 To get Sweep to edit this pull request, you can:
Leave a comment below to get Sweep to edit the entire PR
Leave a comment in the code will only modify the file
Edit the original issue to get Sweep to recreate the PR from scratch
Description
This PR addresses the issue of 'x-hack' instances in the codebase by replacing them with more modern and reliable conditional checks. The 'x-hack' was a shell scripting practice used to ensure compatibility across different shells and systems, but it is now considered obsolete. The 'x-hack' instances were found in the following files:
Summary of Changes
In packages/bsp/nanopim4/nanopim4-pwm-fan.sh:
In packages/blobs/grub/09_linux_with_dtb.sh:
In lib/tools/shellcheck.sh:
These changes improve the codebase by removing the outdated 'x-hack' practice and replacing it with more reliable and modern conditional checks.
Fixes #4.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can: