This PR fixes two issues with the PandasExcelReader class in the llama_hub/file/pandas_excel/base.py file.
The load_data method did not accept a pandas_config argument, causing a TypeError when trying to pass this argument. This PR modifies the load_data method to accept the pandas_config argument.
The __init__ method of the PandasExcelReader class did not correctly initialize the _row_joiner attribute, causing an AttributeError when trying to access this attribute. This PR ensures that the _row_joiner attribute is correctly initialized in the __init__ method.
Changes Made
Modified the load_data method in the PandasExcelReader class to accept a pandas_config argument.
Correctly initialized the _row_joiner attribute in the __init__ method of the PandasExcelReader class.
Testing
I have tested the modified PandasExcelReader class by running the provided example code and confirming that it no longer throws any errors. I have also ensured that the existing functionality of the class is not affected by these changes.
Description
This PR fixes two issues with the
PandasExcelReader
class in thellama_hub/file/pandas_excel/base.py
file.The
load_data
method did not accept apandas_config
argument, causing aTypeError
when trying to pass this argument. This PR modifies theload_data
method to accept thepandas_config
argument.The
__init__
method of thePandasExcelReader
class did not correctly initialize the_row_joiner
attribute, causing anAttributeError
when trying to access this attribute. This PR ensures that the_row_joiner
attribute is correctly initialized in the__init__
method.Changes Made
load_data
method in thePandasExcelReader
class to accept apandas_config
argument._row_joiner
attribute in the__init__
method of thePandasExcelReader
class.Testing
I have tested the modified
PandasExcelReader
class by running the provided example code and confirming that it no longer throws any errors. I have also ensured that the existing functionality of the class is not affected by these changes.Related Issue
This PR addresses the issue #1.
Checklist
Fixes #1.
To checkout this PR branch, run the following command in your terminal: