search

kevinmarrec / nuxt-pwa-module

⚠️ DEPRECATED ⚠️ Zero config PWA solution for Nuxt 3
MIT License
335 stars 32 forks source link

Icons purposes improvement #10

Closed ram-you closed 2 years ago

ram-you commented 2 years ago

Hi, [Suggestion] It would be great to have the possibility to use another image file other than icon.png, for example, icon-maskable.png, if it exists, for icons with purpose maskable

kevinmarrec commented 2 years ago

@ram-you I think that we should keep one icon as source of truth, but generate more images that are dedicated for maskable purpose which is just about adding padding around base icon.

Do you think it would be enough ?

ram-you commented 2 years ago

I think if it's doable, thanks to sharp, it will be good solution.

kevinmarrec commented 2 years ago

Great, I'll have a look then.

kevinmarrec commented 2 years ago

@ram-you Do you have an idea on how much padding a maskable icon requires ?

ram-you commented 2 years ago

Hi, I think it must be as an option. I personally use 15px. But think that it depends of the icon design itself.

kevinmarrec commented 2 years ago

@ram-you Default 15px and an icon option to customise it sounds ok for you then ?

ram-you commented 2 years ago

I think so.