search

kevinmarrec / nuxt-pwa-module

⚠️ DEPRECATED ⚠️ Zero config PWA solution for Nuxt 3
MIT License
335 stars 32 forks source link

iOS Splash Screen Generator #3

Closed xlanex6 closed 2 years ago

xlanex6 commented 2 years ago

Hi @kevinmarrec

I am @xlanex6 as Alex , french dev

I notice // TODO: Launch Screen Image (IOS) in meta.ts

As Nuxt user on my daily job, I will love this feature I already done some work on my previous missions ( Nuxt 2 + PWA) but exited to build it for nuxt3. Also I'm really rookie on OS project, but I already make nuxt3 module (meilisearch) and I would like to work on this feature. Can I fork and make PR to this project ? Is there some guide lines ? where I can find it ?

You can also DM on twitter at @xlanex6, discord (NuxtJS)...

Regards

kevinmarrec commented 2 years ago

Hey @xlanex6 !

You can indeed fork this project, work on a branch on your side then submit a PR !

I first didn't implement it to iterate faster on a working Nuxt 3 module.

As I finished implementing the icons generation yesterday, it should be now really easy to add back the IOS splash screen generation.

It may require small refactor for the generated file names, but adding this feature back shouldn't require much time :)

kevinmarrec commented 2 years ago

@xlanex6 Did you start something ? Just wondering as if you didn't I can take time to do it today or tomorrow and ship it asap :)

xlanex6 commented 2 years ago

Yep https://github.com/xlanex6/nuxt-pwa-module/tree/ios-splash-screen

I generate image , add logo in the middle and inject into meta I can submit PR , even if is not fully finish @kevinmarrec You can comment and I will correct it ? I want finish this evening

kevinmarrec commented 2 years ago

Cool.

Yeah you can create a PR.

We'll first iterate on your branch and then later merge in a branch here if I need to polish some things before finally merging it main and do a release.

EDIT: Didn't see the PR already created, let's move there