kevinmarrec / nuxt-pwa-module

⚠️ DEPRECATED ⚠️ Zero config PWA solution for Nuxt 3
MIT License
338 stars 32 forks source link

support of crossorigin="use-credentials" for basic auth #57

Closed flkrnr closed 1 year ago

flkrnr commented 1 year ago

Thanks for your awesome work so far!

It would be great if we could have support for applications behind basic auth.

I think this should be possible by simply adding crossorigin: 'use-credentials' to the manifest.json link:

https://github.com/kevinmarrec/nuxt-pwa-module/blob/bdd4b4fbb4c78d804e36847b9510a535d393a4c0/src/parts/manifest/index.ts#L29-L32

(Souce: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/crossorigin)

as far as i can tell it is possible in the pwa-module for nuxt2. (https://pwa.nuxtjs.org/workbox#basic-auth) (https://github.com/nuxt-community/pwa-module/issues/94#issuecomment-459175798)

relates to #54

kevinmarrec commented 1 year ago

Closed by #55

Will be available in next release

flkrnr commented 1 year ago

@kevinmarrec i think this needs to be implemented as well when loading the manifest.json (see my reference) #55 just adds interface definitions for other properties but not the property crossorigin nor the actual implementation.