search

kevinmarrec / nuxt-pwa-module

⚠️ DEPRECATED ⚠️ Zero config PWA solution for Nuxt 3
MIT License
334 stars 32 forks source link

Service worker stays registered when enabled is set to false #91

Closed stanislavpodolia closed 1 year ago

stanislavpodolia commented 1 year ago

PWA module for nuxt2 provided an ability to destroy worker if enabled is set to false

When enabled is set to false (default for nuxt dev) workbox module registers a self-destroying worker and cleans window.caches.

I think it's an important feature while the module is being developed because it's crucial to easily get rid of the worker in case something goes wrong. Also info about it not being implemented yet should be added to the readme, I was expecting it to work from the box and got stuck for a while figuring out whats wrong, I think I'm not the only one.

kevinmarrec commented 1 year ago

@stanislavpodolia Thank you for the feedback & details, I'll work on implementing it back in this Nuxt 3 version.

stanislavpodolia commented 1 year ago

@kevinmarrec Awesome job, thanks!