kevinmehall / rust-peg

Parsing Expression Grammar (PEG) parser generator for Rust
https://crates.io/crates/peg
MIT License
1.46k stars 106 forks source link

warn on missing .PHONY entry for common target names #341

Closed mcandre closed 1 year ago

mcandre commented 1 year ago

When "all" target exists, but is missing an entry jn .PHONY, recommend providing one.

This reduces the chances of accidentally skipping the rule's commands, in the case that a file path "all" is ever created.

Conversely, it is exceedingly rare that a genuine artifact "all" would be desired, in the vast majority of makefile projects.

Same for "test" and "install".

This mimicks the behavior of the checkmake linter. Without the detriment of demanding phony declarations when no such target is declared as a makefile rule, presently an open glitch in checkmake.

kevinmehall commented 1 year ago

Wrong repository?