search

kevinmehall / rust-soapysdr

Rust bindings for SoapySDR, the vendor-neutral software defined radio hardware abstraction layer
Apache License 2.0
79 stars 22 forks source link

Apply some linting #28

Closed tommy-gilligan closed 1 year ago

tommy-gilligan commented 1 year ago

Run cargo clippy and cargo fmt on CI. I've run these locally and then gotten them to pass. This also adds --all-features in a few spots to ensure the example binaries are getting built on CI.

kevinmehall commented 1 year ago

I've cherry-picked these fixes, but I've decided not to enforce them on GitHub Actions -- for a project with only sporadic contributions, that's just setting up the next new contributor to run into new warnings introduced by a new clippy version failing their build. Clippy is great as a warning, but I don't think we should block on it because it makes things into breaking changes that don't need to be.

tommy-gilligan commented 1 year ago

4 can probably be closed now