search

kevinobee / Sitecore.Ship

Ship provides a CI service layer for Sitecore
MIT License
71 stars 61 forks source link

Feature/sitecore82 #69

Open dharnitski opened 7 years ago

dharnitski commented 7 years ago

This is fix for Sitecore 8.2 Update 2 breaking API changes.

I made fix portable. Reflection is used to access new API added in Sitecore 8.2 Update 2.

Another option is to start using #ifdef and with it we have to maintain more complicated configuration and generate 2 sets of binaries.

If you think that now it is good time to start maintaining different Sitecore versions I am happy to help. That is how it is implemented for one of my projects - https://github.com/dharnitski/Sitecore.Algolia. I can add something similar to Ship.

This change is Reviewable

steviemcg commented 7 years ago

Thanks for this! Fixed the issue I was having too.

gjaray-geekhive commented 7 years ago

Is there an timeline for when this pull request will be approved and available from nuget? I have a few projects that rely on this fix, while I can just compile and add it myself I'd rather have it available in nuget for future updates.

Steve0x43 commented 7 years ago

Thanks - this fixed the issue we were having 👍. Also keen to get this approved, merged and updated on the version published on NuGet.

scottmulligan commented 6 years ago

Great work on this 8.2 update. We just built the Pull Request code and output our own nuget package that is working!