kevinoconnor7 / osTicket-auth-cas

JASIG CAS Authentication plugin for osTicket
GNU General Public License v2.0
13 stars 8 forks source link

typo in logout function? #15

Closed bpalme closed 7 years ago

bpalme commented 7 years ago

Hey Kevin, I think there is a typo in this signout function on line 157

 static function signOut($user) {
    global $cfg;
    parent::signOut($user);
    $return_url = null;
    if ($cfg != null && !trim($cfg->getUrl())) {
      $return_url = $cfg->getUrl() . "scp/login.php";
    }
    CasAuth::signOut(self::$config, $return_url);
  } 

I think it should be something like this: if ($cfg != null && !empty(trim($cfg->getUrl()))){

Thanks for the plugin! I like the custom service name feature too.

Brent