kevinohara80 / nforce

nforce is a node.js salesforce REST API wrapper for force.com, database.com, and salesforce.com
MIT License
474 stars 167 forks source link

getContentVersionBody #107

Closed CalebEverett closed 8 years ago

CalebEverett commented 8 years ago

https://github.com/kevinohara80/nforce/blob/master/index.js#L590

This is '/versiondata' now instead of '/body'. I'm happy to try to put a pull request together. Do you want to keep the name of the method the same or change it out to "getContentVersionData"?

kevinohara80 commented 8 years ago

Did you find this change in the docs somewhere? I know that the /body uri worked in the past.

I guess I'd prefer to add the getContentVersionData() method for now and find out if the body URI is, in fact deprecated and deprecate the getContentVersionBody() method.

Go ahead and add a getContentVersionData() method. That'd be great.

CalebEverett commented 8 years ago

Will do, here's the link to the doc

https://developer.salesforce.com/docs/atlas.en-us.api.meta/api/sforce_api_objects_contentversion.htm

Did you find this change in the docs somewhere? I know that the /body uri worked in the past.

I guess I'd prefer to add the getContentVersionData() method for now and find out if the body URI is, in fact deprecated and deprecate the getContentVersionBody() method.

Go ahead and add a getContentVersionData() method. That'd be great.

— Reply to this email directly or view it on GitHub https://github.com/kevinohara80/nforce/issues/107#issuecomment-180871834.