search

kevinohara80 / nforce

nforce is a node.js salesforce REST API wrapper for force.com, database.com, and salesforce.com
MIT License
474 stars 167 forks source link

Added opts.isPlatformEvent #143

Closed Stwissel closed 6 years ago

Stwissel commented 6 years ago

Platform Events use the same protocol as the Streaming API. The big difference is the API endpoint which is /event/ instead of /topic/. So a 2 line adjustment does the trick

Stwissel commented 6 years ago

Ahhh. Sorry for that. Merged a branch into my master that shouldn’t be there. Close that one and I’ll recreate the original request which is just 2 lines. On Tue, 5 Dec 2017 at 10:57, kevinohara80 notifications@github.com wrote:

@kevinohara80 requested changes on this pull request.

In general, I think a flag is fine to move forward with but I have several issues with this PR...

1.

Requiring node v6 and adding const keywords will require a semver major version to be released. I'm also not sure if That makes sense. There are still people running much older versions of node (unfortunately). 2.

There are a lot of spacing changes from 2 spaces to 4 spaces for indents. Please keep it to two spaces to make it consistent with the rest of the code base. There is a huge diff on index.js as a result.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kevinohara80/nforce/pull/143#pullrequestreview-81050292, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhHVdhv7E01DgimyD7NEN9xcKTszVBFks5s9KMXgaJpZM4Q0oZz .

-- Mobile message, pegged on glass.

Best regards Stephan H. Wissel http://www.wissel.net/

kevinohara80 commented 6 years ago

I believe I'm going to merge the other PR that is open. It's essentially the same thing and provides examples and docs. Thanks!