kevinohashi / php-riot-api

PHP Wrapper for Riot Games API
MIT License
75 stars 40 forks source link

new function in riot-api #60

Open toalt opened 7 years ago

toalt commented 7 years ago

Someone with privilges could add following code:

//Returns the challenger ladder.
public function getChallenger() {
    $call = 'league/challenger?type=RANKED_SOLO_5x5';
    //add API URL to the call
    $call = self::API_URL_2_5 . $call;
    return $this->request($call, true);
}
    //Returns the master ladder.
public function getMaster() {
    $call = 'league/master?type=RANKED_SOLO_5x5';
    //add API URL to the call
    $call = self::API_URL_2_5 . $call;
    return $this->request($call, true);
}

the challenger ladder already exists, but the master ladder was not impl.

kevinohashi commented 7 years ago

You can submit a pull request, it's the easiest way to get code integrated into the repo

On Fri, Dec 9, 2016 at 7:16 AM, toalt notifications@github.com wrote:

Someone with privilges could add following code:

//Returns the challenger ladder. public function getChallenger() { $call = 'league/challenger?type=RANKED_SOLO_5x5'; //add API URL to the call $call = self::API_URL_2_5 . $call; return $this->request($call, true); } //Returns the master ladder. public function getMaster() { $call = 'league/master?type=RANKED_SOLO_5x5'; //add API URL to the call $call = self::API_URL_2_5 . $call; return $this->request($call, true); }

the challenger ladder already exists, but the master ladder was not impl.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kevinohashi/php-riot-api/issues/60, or mute the thread https://github.com/notifications/unsubscribe-auth/ABJcgj2EHlmfLj6nA1ZAYA-NaR1XgeRJks5rGUaUgaJpZM4LI4Vf .