kevinoo / phpWhois

phpWhois general repository
https://phpwhois.pw
GNU General Public License v2.0
10 stars 1 forks source link

composer update unzip error #4

Closed yespire closed 10 months ago

yespire commented 10 months ago

This is not a critical problem.

composer update command

  1. on Linux (redhat/centos), works as expected
  2. on Mac, yields the following error message when installing the package for the first time:

    
    Failed to extract kevinoo/phpwhois: (50) '/usr/bin/unzip' -qq '<PROJECT>/vendor/composer/tmp-7bba08f253d7ee13f07301f6286873fe.zip' -d '<PROJECT>/vendor/composer/a8016ac8'

error: cannot create /vendor/composer/a8016ac8/kevinoo-phpWhois-8ca26c5/tests/fixtures/?????.????.txt Illegal byte sequence

kevinoo commented 10 months ago

Hi @yespire

on Mac, are you simply performing a composer update in your project? Try running composer require kevinoo/phpwhois :pray:

Let me know, Kevin

yespire commented 10 months ago

@kevinoo

I'm getting the same error message when installing on mac:

  1. composer require kevinoo/phpwhois
  2. add "kevinoo/phpwhois": "^6.3", to composer.json, then run "composer update"
yespire commented 10 months ago

"????.????.txt" looks like "tests/fixtures/smile.coop.txt"

Found a thread also reporting unzip throwing the same error message: https://github.com/adamhathcock/sharpcompress/issues/315

kevinoo commented 10 months ago

I think the problem is this file tests/fixtures/рег.рф.txt :disappointed:

if I should be create a dev-branch, can you test the version on MacOS for me? :pray:

yespire commented 10 months ago

@kevinoo

Of course, just ping me

kevinoo commented 10 months ago

Hi @yespire sorry for the late.

I created the "dev-4-composer-update-unzip-error" branch trying to correct the problem: could you use that branch as source when you can? :pray: I also updated the repository on Packagist (for Composer)

yespire commented 10 months ago

@kevinoo

Just verified, the patch fixed the unzip issue Thank you for the fix!

kevinoo commented 10 months ago

Thank you very much @yespire for your availability! 🙏🏻

As soon as I can, I will release the patch to the main branch 💪🏻