search

kevinpapst / freshrss-youtube

A FreshRSS extension to directly embed videos from YouTube channel feeds
58 stars 14 forks source link

thumbnail still showing under video player #21

Closed bwees closed 3 months ago

bwees commented 11 months ago
Screenshot 2023-08-03 at 1 09 07 PM

The thumbnail and content is still showing under the video embed even after I have show content deselected. I tried to nail down the bug and it appears that even if you just pass the iframe code (or even text for that matter) from here:

https://github.com/kevinpapst/freshrss-youtube/blob/master/xExtension-YouTube/extension.php#L186

FreshRSS still renders the feed content beneath the video player. When I turn on show content I basically get the player and then the description then the thumbnail and description again:

Screenshot 2023-08-03 at 1 15 27 PM

It appears as if FreshRSS is appending the feed content regardless of what this extension outputs. Is this due to the use of _content variable when setting the html?

I am on v1.21.0 that was released 4 days ago so it may be a freshRSS bug, I will try to go to 1.20.0 and see if that fixes it

bwees commented 11 months ago

It appears to fix itself on 1.20.2, will open a freshRSS issue and mention this issue here.

kevinpapst commented 11 months ago

I am seeing the same issue. But I didn't have the time to investigate.

What I can tell you: the setting worked properly in the past. You either had the video player alone or (if setting was active) the player and the content below.

The thumbnail is new, also the fact that the content is injected, no matter what. There was some kind of change in FreshRSS core.

kevinpapst commented 3 months ago

Closing here. If the issue persists, please re-open the issue at https://github.com/FreshRSS/Extensions