kevinputera / pe

0 stars 0 forks source link

DG F3: Creating a Food should say that the prereq is that food does not exist #6

Open kevinputera opened 4 years ago

kevinputera commented 4 years ago

Screenshot 2020-04-17 at 3.08.59 PM.png

I believe you guys should say that the pre-requisite for update to create a new item is that the item should not be there in the first place. This is especially important as the update command can be used to update an existing item too!

nus-pe-bot commented 4 years ago

Team's Response

Hi there.

It should be understood that 'Creating' in the title in this case would mean to add a new Food item. It can therefore be easily understood by new developers (or the reader of this section).

Hence, the pre-requisite does not have to be overly specific in re-iterating this fact, which is unnecessary for the reader (a future developer who understands this) and hinders coherence.

image.png

Severity (if any): low because this does not affect normal operation (if any)/brings minor inconvenience (if any). Note that this is explained despite us rejecting it, as the Github forum requires us to explain any changes to severity.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: > It should be understood that ‘Creating’ in the title in this case would mean to add a new Food item. It can therefore be easily understood by new developers (or the reader of this section).

Hence, the pre-requisite does not have to be overly specific in re-iterating this fact, which is unnecessary for the reader (a future developer who understands this) and hinders coherence.

I disagree with this. We can similarly say that the pre-requisite of launching Calgo successfully trivial, since if the app doesn't launch the tester wouldn't even bother to try out the test cases supplied. However, this pre-requisite is provided in the test case. If that's the case, why not be more specific and say that the food to be updated must not exist in the database? I feel like this is a very needed pre-requisite, since it's part of the command being tested (if the food already exists, no new food will be created).


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: I feel like this pre-requisite that I deem missing is really an important one. The command update can be used to either update an existing item or create a new item; thus, it should be mentioned that the pre-requisite of this test case is such that the food hasn't existed yet. It's hence a pretty severe bug.