search

kevinresol / hxgenjs

Extensible JS generator for Haxe
57 stars 16 forks source link

Don't generate empty Abstract implementations #19

Closed benmerckx closed 6 years ago

benmerckx commented 6 years ago

Fixes #18

kevinresol commented 6 years ago

Do we also need to check cls.statics? If I understand correctly abstract impl classes should contain no instance members but only static ones?

benmerckx commented 6 years ago

Yes we do :) Let me try and add a test here.

benmerckx commented 6 years ago

It's actually only statics that need to be checked, as there's never an instance created. My first try was a bit too fast.

kevinresol commented 6 years ago

Looks very nice. Thanks!