search

kevinresol / react-native-sound-recorder

Simplest Sound Recorder for React Native
MIT License
119 stars 36 forks source link

Add run time permissions on Android #28

Closed Ansalibrahim closed 5 years ago

Ansalibrahim commented 5 years ago
kevinresol commented 5 years ago

Is this consistent with iOS?

Ansalibrahim commented 5 years ago

iOS already shows permissions when we try to access the mic. So no conflict with iOS app.

kevinresol commented 5 years ago

Ok, can you undo the white space changes and force push again? I don't want to mess up the blame history.

Ansalibrahim commented 5 years ago

@kevinresol Please check now.

kevinresol commented 5 years ago

Thanks!

ansal-exp commented 5 years ago

@kevinresol, when does this, will get published on NPM? The latest version 1.3.3 does not contain these changes.

kevinresol commented 4 years ago

This is now reverted. Please request permissions manually.