search

kevinresol / react-native-sound-recorder

Simplest Sound Recorder for React Native
MIT License
119 stars 36 forks source link

fix AVAudioRecorder release #39

Closed cark1 closed 4 years ago

cark1 commented 4 years ago

Fixes kevinresol/react-native-sound-recorder#38 Now AVAudioRecorder is released in the "audioRecorderDidFinishRecording" of the AVAudioRecorderDelegate. In this way there is not problem anymore recording long files (more than 10 minutes).

kevinresol commented 4 years ago

Thanks for the fix. But I wonder if the duration is correct in this case?

I assume that before audioRecorderDidFinishRecording the recording is not finished and perhaps we will get an incorrect value for "duration"?

kevinresol commented 4 years ago

Merging for now and will open a new issue to track my question above

cark1 commented 4 years ago

Merging for now and will open a new issue to track my question above

Ok, perfect. I'll send a new pull request in few minutes with a fix for the duration as well.