search

kevinrood / teamcity_formatter

TeamCity cucumber output formatter
Apache License 2.0
5 stars 8 forks source link

Closes kevinrood/teamcity_formatter#1 #2

Closed ailjushkin closed 8 years ago

ailjushkin commented 8 years ago

Fixed dir and path names

ailjushkin commented 8 years ago

Tested this fix locally (changed gem files in local ruby distr)

kevinrood commented 8 years ago

@PositiveAlex thank you for this pull request.

While it is not standard practice in Ruby to auto-load constants, I can see why you would want support for this approach since cucumber has added code to support loading formatters in this manner (see here and here).

I've merged this code and published a new version of the gem (0.8.1). Thanks again for your contribution! :smile:

ailjushkin commented 8 years ago

Thank you, man, and thanks for that git commits, that was interesting to read! :)

пт, 1 янв. 2016, 23:13, Kevin Rood notifications@github.com:

@PositiveAlex https://github.com/PositiveAlex thank you for this pull request.

While it is not standard practice in Ruby to auto-load constants, I can see why you would want support for this approach since cucumber has added code to support loading formatters in this manner (see here https://github.com/cucumber/cucumber-ruby/blob/061fc7ac9b5e8f09c16c4398835719c61617178e/lib/cucumber/configuration.rb#L185-L191 and here https://github.com/cucumber/cucumber-ruby/blob/061fc7ac9b5e8f09c16c4398835719c61617178e/lib/cucumber/constantize.rb#L4-l24 ).

I've merged this code and published a new version of the gem (0.8.1). Thanks again for your contribution! [image: :smile:]

— Reply to this email directly or view it on GitHub https://github.com/kevinrood/teamcity_formatter/pull/2#issuecomment-168335454 .