search

kevinsawicki / gitective

Find the Git commits you're looking for
http://gitective.org
117 stars 53 forks source link

Fixes for recursion and deleted blobs for getLastCommits #4

Closed gitblit closed 12 years ago

gitblit commented 12 years ago

I found two bugs in the algorithm (which works wonderfully!). Without diffWalk recursion you end up with a map full of mostly null values and without the key check deleted blobs are incorrectly added to the map.

gitblit commented 12 years ago

I have another change proposal. TreeUtils.diffWithParents includes merge commits. I think this will break the determination of the actual last author in some cases.

kevinsawicki commented 12 years ago

Thanks for this! I will merge this in later today and also add some unit test for merge commits and we can work from there.

kevinsawicki commented 12 years ago

Merged into master as commit 0770e6a99933e624a0b00ce5ce23913d8986fc96