kevinsawicki / monokai

Monokai Atom Syntax theme
241 stars 133 forks source link

Cursor is really hard to see when used with the Vim plugin #10

Closed jamesgecko closed 9 years ago

jamesgecko commented 10 years ago

When using the Vim plugin in command mode, the cursor is invisible, only the text highlight may be seen. This makes it a lot harder to tell where the cursor is, especially because it means that the cursor is invisible when it's over whitespace.

screenshot 2014-03-10 10 01 50

tsujp commented 10 years ago

It actually broke in the newest update of Vim Mode. I had Vim 0.87.0 installed (i think), and when they updated to 0.9.0 (or whatever the newest update was) it broke.

Maybe it's a styling issue?

jarinudom commented 10 years ago

There appears to be a way for theme developers to handle this:

https://github.com/atom/vim-mode/pull/123

jarinudom commented 10 years ago

As a temporary fix, I just put this in my stylesheet:

.vim-mode.command-mode:not(.mini) .cursor,
.vim-mode.command-mode:not(.mini) .cursor.blink-off {
  background-color: #fff;
}
msarchet commented 10 years ago

The plugin needs to define a syntax-variables.less and define a cursor color in there. Working on a pull request for this per https://github.com/atom/template-syntax/blob/master/stylesheets/syntax-variables.less. The vim-mode plugin uses the @syntax-cursor-color variable to set the block caret to the right color when in normal mode.

svanharmelen commented 9 years ago

@jamesgecko it's been a while so before diving into this one, could you let me know if this is still an issue, or that it is solved in the mean time?

Thanks!

jamesgecko commented 9 years ago

Looks to be resolved.