search

kevinsawicki / monokai

Monokai Atom Syntax theme
241 stars 133 forks source link

Fix broken highlighting for JSON tree-sitter grammar #105

Closed caleb531 closed 3 years ago

caleb531 commented 5 years ago

Description of the Change

This PR fixes the slightly-broken highlighting for JSON files when @Ben3eeE's tree-sitter JSON grammar is applied. See atom/language-json#68.

These changes are backwards-compatible with the current first-mate JSON grammar.

Before:
Screen Shot 2019-04-13 at 10 49 22 AM

After:
Screen Shot 2019-04-13 at 10 49 39 AM

Benefits

The highlighting for JSON files (the way Monokai highlighted them for the first-mate grammar) is restored.

Possible Drawbacks

Perhaps some users do not like the green highlighting for key names, though I personally prefer them (and at any rate, it's nicer than having the key names colored the same as string values).

I'm also open to considerations for a different link style other than blue/underline. I don't have much of a preference either way on that.

caleb531 commented 5 years ago

@kevinsawicki @Ben3eeE Any chance on this getting merged? Atom 1.38 has been released with https://github.com/atom/language-json/pull/68, which currently breaks JSON highlighting for this syntax theme. Merging in this PR will fix that—I've been running off my monokai fork and it's been working well so far.

Related: https://github.com/atom/language-json/issues/77

caleb531 commented 3 years ago

@gustavoalfaro Do you have any insight into when a new release of this theme (containing this merged PR) may be pushed to apm?

gustavoalfaro commented 3 years ago

I can create a release soon, I was taking a look into this because looks like I'm the only only one in charge of the theme now, so I'll check some more PRs and get up to speed with the project to release a new version with your changes

gustavoalfaro commented 3 years ago

@caleb531 I just released the v0.26.0 with these changes!