search

kevinsawicki / monokai

Monokai Atom Syntax theme
241 stars 133 forks source link

Highlight color changed in 0.26 #109

Closed marnen closed 3 years ago

marnen commented 3 years ago

I just upgraded to Monokai 0.26, and the highlight color used for files in the tree view, tabs, and checkboxes changed from blue to green. (I wouldn't expect a syntax theme to affect this at all, but apparently it does.) Which color variable is involved here? I've tried inspecting the elements in question, but I can't really tell...

gustavoalfaro commented 3 years ago

Do you have a screenshot?

marnen commented 3 years ago

image image image

All the blue elements in these images changed to green when I upgraded.

gustavoalfaro commented 3 years ago

It's still green for me: image

image

marnen commented 3 years ago

@gustavoalfaro Yes, your green screenshots look like what I get in 0.26, and why I opened this issue. The blue screenshots are from another installation that’s running an older version of the same theme.

marnen commented 3 years ago

So, to recap: when I upgraded from 0.24 to 0.26, the highlight color changed from blue (0.24) to green (0.26). How do I change it to blue in 0.26? I didn’t see an obvious LESS variable.

sundaycrunk commented 3 years ago

I've got the same issue. I went through every file in the monokai folder, and tried changing every possible color that could be resulting in this green highlight and background overlay/underlay and it's still there...

Screen Shot 2020-11-07 at 1 21 39 pm

caleb531 commented 3 years ago

@marnen This is because, if you look at the diff between Monokai v0.24.0 and v0.26.0:

git diff v0.24.0..v0.26.0

You will see that the @syntax-background-color changed in syntax-variables.less:

- @syntax-background-color: @dark-gray;
+ @syntax-background-color: @sundried-clay;

And, by consequence, the one-dark-ui theme dynamically sets the focus color (i.e. green vs. blue) based on the saturation of the @syntax-background-color:

Screen Shot 2020-11-08 at 9 38 56 AM

However, you can form the monokai theme and change the @syntax-background-color to @dark-gray in syntax-variables.less, then relink it to your local packages. I've already taken the liberty of creating the patched fork for you:

git clone https://github.com/caleb531/monokai.git
cd monokai
rm -rf ~/.atom/packages/monokai
apm link

Restart Atom, and you're done!

marnen commented 3 years ago

@caleb531 Huh, interesting. I did see the change from @dark-gray to @sundried-clay, but it never would have occurred to me that that changed the highlight color from blue to green!

Thanks for the patch, too; I'll look at it. I wonder if this should be considered a bug in One Dark...

gustavoalfaro commented 3 years ago

Ok makes sense, I'm going to release a fix for this!

Nerd2k commented 3 years ago

@gustavoalfaro what was the reason for the change from @dark-gray to @sundried-clay in the first place? I personally liked it better the way it looked with @dark-gray.

gustavoalfaro commented 3 years ago

I think that was a change from @ppete2 who was trying to make it more similar to the original theme from Sublime Text but I also like the @dark-gray since is more comfortable for the eyes.

Nerd2k commented 3 years ago

I think that was a change from @ppete2 who was trying to make it more similar to the original theme from Sublime Text

Ok, I see.

but I also like the @dark-gray since is more comfortable for the eyes.

Yes definitely, it's the same for me.

gustavoalfaro commented 3 years ago

Fix released in v0.27