search

kevinsawicki / monokai

Monokai Atom Syntax theme
241 stars 133 forks source link

Removed the unnecessary gutter color which invalidates other colors, such as atom-jshint-error (added by atom-jshint package). #15

Closed vinceyuan closed 10 years ago

vinceyuan commented 10 years ago

When atom-jshint detects there is an error in a .js file, it makes the line number red. However it does not work in the existing monokai theme. This unnecessary gutter colour invalidates other colours.

vinceyuan commented 10 years ago

Is anybody here?

kevinsawicki commented 10 years ago

Thanks for the ping will take a look soon

vinceyuan commented 10 years ago

Reverted version.

kevinsawicki commented 10 years ago

I'm not sure this is the right change, look at how it makes {}:, characters look in JSON files (they are almost invisible now):

screen shot 2014-04-10 at 9 07 41 am

vinceyuan commented 10 years ago

It does not happen on my mac. It should not happen because I did not change .gutter colour. What I removed is what was added in Commit 9ba3b86e93656f5c73a559e7246cfd1b47122a93 by Jon. Need restart Atom?

kevinsawicki commented 10 years ago

But you also deleted the & selector along with the .gutter selector

kevinsawicki commented 10 years ago

I mean you deleted these colors from the & selector which appears to have affected the default colors used for lines.

vinceyuan commented 10 years ago

I am really sorry. I modified wrong code in a separate repository. It should be fixed now. Please try.

kevinsawicki commented 10 years ago

No problem, thanks for this.

vinceyuan commented 10 years ago

Thank you :+1:

kevinsawicki commented 10 years ago

I just published a 0.6.0 release with this fix and a couple other tweaks to bring this theme up to date, please let me know if you see any issues with this new release.

vinceyuan commented 10 years ago

It looks very good. :+1: