kevinsawicki / monokai

Monokai Atom Syntax theme
241 stars 133 forks source link

Remove underline from class definitions #30

Closed sadovnychyi closed 9 years ago

sadovnychyi commented 9 years ago

Most of people switch from Sublime Text, and its a pain to see class names with underlines.

asantos3 commented 9 years ago

This also affects my theme, can you give me example code?

sadovnychyi commented 9 years ago

Example code of what?

On Fri, Jan 23, 2015, 23:43 André Santos notifications@github.com wrote:

This also affects my theme, can you give me example code?

— Reply to this email directly or view it on GitHub https://github.com/kevinsawicki/monokai/pull/30#issuecomment-71212001.

asantos3 commented 9 years ago

Of what you are changing, e.g. sample code from some affected languages.

sadovnychyi commented 9 years ago

https://github.com/kevinsawicki/monokai/commit/7bf6d088575f618c1016aec220503b6de88f36d1

On Sat, Jan 24, 2015, 10:45 André Santos notifications@github.com wrote:

Of what you are changing, e.g. sample code from some affected languages.

— Reply to this email directly or view it on GitHub https://github.com/kevinsawicki/monokai/pull/30#issuecomment-71297098.

asantos3 commented 9 years ago

C'mon, not that. Can you give me examples when the text gets that underlined decoration?

sadovnychyi commented 9 years ago

Sorry, cannot take a screenshot right now, but it's definitely appears on python classes. Try something like:

class Test(object):
  pass

On Sat, Jan 24, 2015, 20:39 André Santos notifications@github.com wrote:

C'mon, not that. Can you give me examples when the text gets that underlined decoration?

— Reply to this email directly or view it on GitHub https://github.com/kevinsawicki/monokai/pull/30#issuecomment-71314990.

sadovnychyi commented 9 years ago

Finally I'm able to take a screenshot, so here we are, the ugly underscores: image

asantos3 commented 9 years ago

Those are definitely ugly, thanks! :)