Make text selections only show the select in the text area

kevinsawicki / monokai

Monokai Atom Syntax theme

241 stars 133 forks source link

Make text selections only show the select in the text area #46

Closed svanharmelen closed 9 years ago

svanharmelen commented 9 years ago

Currently it also selects the gutter which seems a little weird and uncommon.

Before:

After:

sadovnychyi commented 9 years ago

It was in my styles.less for 6 months already. Support! :+1:

svanharmelen commented 9 years ago

@kevinsawicki are you OK with this change? If not, please let me know any concerns so we can look at them and get towards merging this one in...

Thx!

sadovnychyi commented 9 years ago

Personally I don't think that line numbers should be highlighted at all (they are bold on your screenshot) like in sublime text.

svanharmelen commented 9 years ago

Ok... I must admit I like the bold line numbers. Next to that it seems a very subtle compromise between the previous behaviour, having full highlighting, and having no highlighting at all.

svanharmelen commented 9 years ago

@kevinsawicki I know I'm chasing you on several PR's in different repo's now, but you seem to be either owning the repo or being one of the few guys merging stuff :smiley:

So could you please have a look and let me know your take on this and/or merge it of OK? Would be very much appreciated...

svanharmelen commented 9 years ago

@kevinsawicki any thought on this? Would be great to get this one merged...

svanharmelen commented 9 years ago

@kevinsawicki what can/must I do to get your attention to this one for a minute? I know your busy, but this one is open for about 3 months now and really seems a very small (but nice) fix/tweak...

Thanks!

kevinsawicki commented 9 years ago

Sorry for the delays on this one, missed this whole set of pings since I don't really use this theme anymore, I use One Dark.

Published this as 0.15.0

kevinsawicki commented 9 years ago

Thanks for this though :+1:

svanharmelen commented 9 years ago

@kevinsawicki no problem and thanks!

And sorry for being so bold, but if your looking to get this puppy a new maintainer I would be more then happy to takeover ownership and take care of this one....

Just so you know :wink: