kevinshen56714 / SkyOffice

Immersive virtual office built with Phaser, React, Redux, PeerJS, and Colyseus.
https://sky-office.co/
MIT License
930 stars 289 forks source link

Feat/virtual joystick #63

Closed jga-dev closed 1 year ago

jga-dev commented 1 year ago

New feature added: Basic Virtual Joystick

Hi, I decide implement this feature because it appears to be in high demand. Hope you find interesting.

Description:

Captura de Pantalla 2023-02-20 a las 1 20 20

For implement this, I use this component: https://github.com/elmarti/react-joystick-component

Note: This feature will conflict with this PR: https://github.com/kevinshen56714/SkyOffice/pull/62 I can take care of resolving conflicts

Related issues:

netlify[bot] commented 1 year ago

Deploy Preview for skyoffice ready!

Name Link
Latest commit ae401962dcc6e12b91b5e7b67e5692d52829e5b4
Latest deploy log https://app.netlify.com/sites/skyoffice/deploys/63f552bab2834b0008140063
Deploy Preview https://deploy-preview-63--skyoffice.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

DaxChen commented 1 year ago

This is awesome! Thanks for your contribution, please feel free to reach out if any of the comments are unclear or if you don't agree on any of them! BTW I did this review together with Kevin.

jga-dev commented 1 year ago

@DaxChen Hi, thanks for the review. I just uploaded a new commit with the changes. Anything else let me know 😊👍

MariaJesusGomez commented 1 year ago

Oohh, Sounds great! As soon as this PR is resolved I'll pull the project with this feature.

jga-dev commented 1 year ago

@DaxChen Hi, thanks again for your review. I've applied all the changes you have commented. If you see anything else feel free to let me know.