kevinsullivan / cs2120f21

2 stars 92 forks source link

Make container run non-root user #1

Open kevinsullivan opened 3 years ago

kevinsullivan commented 3 years ago

The container is running as root. To make it harder to make catastrophic mistakes, it'd be better to run as a non-root but sudo user.

Solution: Add vscode user creation to DOCKERFILE and uncomment line in devcontainer.json that sets the container user to "vscode".

exb3dg commented 3 years ago

I'm not sure if I'm running into this problem. However, after a entered the GitHub URL it tells me an error occurred when setting up the container.

If this is what you're referring to, I don't quite understand how to do the solution.

image

kevinsullivan commented 3 years ago

Be sure docker is running. Let me know if they doesn't work.

On Thu, Aug 26, 2021, 10:09 PM exb3dg @.***> wrote:

I'm not sure if I'm running into this problem. However, after a entered the GitHub URL it tells me an error occurred when setting up the container.

If this is what you're referring to, I don't quite understand how to do the solution.

[image: image] https://user-images.githubusercontent.com/89548775/131060493-4d79e122-9c46-40a6-be49-ee705e7d4a1c.png

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/kevinsullivan/cs2120f21/issues/1#issuecomment-906870255, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVEX5M4C7DTAMYOHX57ALLT63XVPANCNFSM5C2MF2BA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

exb3dg commented 3 years ago

image

From my understanding docker is running. VSCode tells me the Git clone failed.

image

I can open it in a Recovery Container. However, I don't believe that's what is wanted because when I open leantest.lean all the text is white:

image

kevinsullivan commented 3 years ago

Ok, next hypothesis/experiment. Could you select the VSCode Remote Containers option to "Rebuild Container".

On Mon, Aug 30, 2021 at 11:28 AM exb3dg @.***> wrote:

[image: image] https://user-images.githubusercontent.com/89548775/131363150-518280b0-614b-4185-9b19-5cbf30e48079.png

From my understanding docker is running. VSCode tells me the Git clone failed.

[image: image] https://user-images.githubusercontent.com/89548775/131363291-b370e84c-9d3d-4f14-916b-97843b3c0db9.png

I can open it in a Recovery Container. However, I don't believe that's what is wanted because when I open leantest.lean all the text is white:

[image: image] https://user-images.githubusercontent.com/89548775/131364015-791a6cb4-97ea-4d30-a859-ea8187fc72f4.png

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/kevinsullivan/cs2120f21/issues/1#issuecomment-908439662, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVEX5O6DZRN6OPIB45SM53T7OPS5ANCNFSM5C2MF2BA .

exb3dg commented 3 years ago

After rebuilding the container, it looks like it's now in the DEV CONTAINER: LEANVM instead of the recovery container. However, it still seems like something is going wrong.

image

kevinsullivan commented 3 years ago

SHow me after class, ok? No worries about quiz. We're still in the settling in phase of class. --KS

On Mon, Aug 30, 2021 at 11:51 AM exb3dg @.***> wrote:

After rebuilding the container, it looks like it's now in the DEV CONTAINER: LEANVM instead of the recovery container. However, it still seems like something is going wrong.

[image: image] https://user-images.githubusercontent.com/89548775/131367421-481d7119-7e46-43bd-87fa-77a609c2c071.png

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/kevinsullivan/cs2120f21/issues/1#issuecomment-908457515, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVEX5MRLBQVHYD46MOSIHDT7OSIRANCNFSM5C2MF2BA .