Reducing Capacity Won't Reduce Capacity - Githubissues

kevinthedang / discord-ollama

Discord Bot that utilizes Ollama to interact with any Large Language Models to talk with users and allow them to host/create their own models.

Creative Commons Attribution 4.0 International

42 stars 4 forks source link

Reducing Capacity Won't Reduce Capacity #39

Closed kevinthedang closed 2 months ago

kevinthedang commented 2 months ago

Issue

The codebase does not account for automatic resizing upon changing the capacity. It only "literally" changes the capacity value.

// check if we can push, if not, remove oldest
if (msgHist.size() === msgHist.capacity) msgHist.dequeue()

Solution

Probably just do a while loop instead to reduce on new message. This should handle it fine.
I do not believe it needs to be done for post query.

// check if we can push, if not, remove oldest
while (msgHist.size() >= msgHist.capacity) msgHist.dequeue()