Closed kevinthedang closed 1 week ago
@kevinthedang I think this issue (i.e., cleaning docker deployment/delivery stuff out of node configuration) may require the success of #61 so that these commands can be documented for developers, but not accessible unless run manually on command line for whatever deployment purpose necessary.
@JT2M0L3Y
The intended purpose of #61 is to deploy the docker image through some kind of .yml
file that will allow it to push to some registry.
I am unfamiliar with the possibility of creating manually run GitHub pipelines but I know they are possible in GitLab.
In my (10 seconds of) research, it looks like some pipeline needs workflow_dispatch
to be manually run. Ideally, this pipeline should be created in master and can only be dispatched by users with privilege to the repository.
What I am getting at is that we do not need to rely on #61 for this issue. Let me know what you think.
@kevinthedang
We should aim to remove the docker environment setup from the package.json as it blends deployment and configuration together.
What I mean is, to remove the "clutter" from the scripts commands, we require another method of providing the docker environment (publishing the docker environment instead). In this way, we protect the docker compose process from modification.
It may not be directly dependent, but #61 is still related to this issue.
Issue
There are a lot of scripts in
package.json
and it would be nice if we just had less more concise scripts to run so there is no need for large scripts to type in.Solution
package.json
as best as possible. If there are no changes or cleanup that can be made, close this issue.References