kevintxwu / outgame-rails

Super cool application!
0 stars 0 forks source link

Event framework #6

Closed dwarrier closed 10 years ago

dwarrier commented 10 years ago

Made a lot of changes, REALLY messy, sorry! I didn't want to figure out the CSS so I did some dirty bastardized embedded ruby :) App root is now at event index, we can change that later. All I did was move current events into database seeds and add event create, show, and destroy functionality. No player profiles or accounts yet.

Some TODO's on my side:

upload an image for new/update event figure out how to deal with dates! change hint for event_type select on edit info page (doesn't show current value) add 'game types' array to show types (currently a hardcoded string)

dwarrier commented 10 years ago

Uh guys... How are we doing event/user relationships again? We have accounts and players right now. Should we only have players and managers that inherit from User and no Account model? I don't know why we need accounts.

I need to edit this and take out a couple models if we aren't using accounts anymore.

kevintxwu commented 10 years ago

Yes, I agree we should only have players and managers that inherit from User. It sounds like Account is just the Manager model with the wrong name, as in if we just rename the Account model to Manager would that work?

By the way, if it ends up that things are quite right with the HTML/CSS, that's okay. I can go in later and make those fixes. For now just try your best to follow the template and hopefully the pre-written CSS ids and classes will take care of most of it.

chenhoward commented 10 years ago

I agree with Kevin. We should have our general account/user model. Then during an event we have manager(s) and players. A user/account can be a manager in one event while a player in another. An event's players should always look up to a user with a matching email and that player model would hold data like the users score in that certain event and whatnot. The lookup isn't required though as people should be able to be players without having an account in outgame. Atleast this is the way I see it organized and correct me if I'm misguided about what we are doing or suggestions LOL

kevintxwu commented 10 years ago

Howard's pull request has been merged! The database should set up to be properly using users. Now we can built managers/players/events on top of this.

dwarrier commented 10 years ago

Uh. Howard?! How do I set up postgres? Any way you can merge my changes for me in the meantime? The only conflicts are in .gitignore, schema.rb, and development.log

chenhoward commented 10 years ago

Hey Deeps this is the general steps for installing pg.

I'm assuming you have brew so you can just go

$brew install pg

then you do

$createdb outgame_development

then you config your database.yml

chenhoward commented 10 years ago

if your branch ready I can merge your changes if you want. Also feel free to text/call me if you need help