kevintyj / prlint

Github PR title checker using Conventional Commits spec on Changesets
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

feat: Migrate to v9 #13

Closed kevintyj closed 2 weeks ago

kevintyj commented 2 weeks ago

Migrates commitment to v9 (ESM support migration)

BREAKING!: Drops CJS support (will try to add CJS support again later)

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.83%. Comparing base (59797d1) to head (1ad28ed).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #13 +/- ## =========================================== - Coverage 100.00% 98.83% -1.17% =========================================== Files 4 4 Lines 123 172 +49 Branches 23 28 +5 =========================================== + Hits 123 170 +47 - Misses 0 2 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kevintyj commented 2 weeks ago

Welp that was a nice try...

Edit: I may have over engineered the solution from the beginning, with all of the dependencies like ncc, cosmiconfig, v19 commitlint update, esm <-> cjs backwards compatibility, and a lot of other minor issues added a lot of unwanted complexity to the problem. The problem being why I had to be the one trying to parse the configuration file when there already are built in exported functions.

Solution: I will be releasing a breaking change v2 which will update the commitlint version to v19 as referenced to #12 as well as adding support for descriptions as referenced here: #11. However, this will drop the support for:

Thats it. But to be honest, it was kind of the only feature as well... so... I came up with a compromise, which I genuinely think is a better solution:

I will try to implement these features in the upcoming days will start raising new PRs