search

kevinvincent / ha-wyzesense

A Home Assistant Component to interface with the WYZE Sense hub and sensor system
370 stars 101 forks source link

Remove scan of dongle for paired sensors #35

Closed photinus closed 4 years ago

photinus commented 5 years ago

Stores the sensors in a local file instead of relying on the dongle to return paired sensors. Resolved Fixes #29

shauder commented 5 years ago

I don't think you actually need to write them to a file and read from the file. The error check for mac size should be enough right?

photinus commented 5 years ago

So, I'm writing the macs out to the file to allow for the entity setup on initialization of the platform. Otherwise it will pick them up as they check in, but at least in my use case I want them to always show up. If I dont set them up at initialization I end up with error icons in my front end till they check in for the first time.

kevinvincent commented 5 years ago

WIll test your contribution this weekend and push it out! Thank you!

photinus commented 5 years ago

Any chance we can merge this change in? I've had a few people message me about the issue popping up for them.

photinus commented 4 years ago

Would you be interested/willing to add me as a maintainer of the repo so I can help keep this updated and push forward with development? I'm happy to help and keep things moving.

kevinvincent commented 4 years ago

Hi @photinus Sorry I've been insanely busy these last few months trying to graduate from my undergrad. I'd definitely be willing to add you as a maintainer. Please look out for the email from github. Sorry about the lack of response.

Thank you.

kevinvincent commented 4 years ago

@photinus Will this result in devices disappearing on restart until they are triggered for the first time? I assume this will happen when upgrading to this version?

kevinvincent commented 4 years ago

Basically the README says this:

  • Restart HA and the sensors you have already bound to the hub (using the wyze app for example) will show up in your entities as off with assumed_state: true and no device_class. These will update and other attributes will be added once the component hears from the sensor for the first time.

But that is now wrong as the sensors will only show up once it triggers for the first time right? I can update the README and create a new release to push it out to HACS if you confirm this.