search

kevinwolz / hisafer

An R toolbox for the Hi-sAFe biophysical agroforestry model
6 stars 4 forks source link

backcompatibility problem : harmonicweightedMean deleted from general parameters #152

Open mariegosme opened 3 years ago

mariegosme commented 3 years ago

during 'build_hisafe', the simulation loses the 'harmonicweightedMean' parameter in the general parameters, therefore Hi-safe 4.0 doesn't run (the output folder is created but remains empty).

Workaround: manually enter harmonicweightedMean= 1 in the general parameters file after using build_hisafe() and before using run_hisafe() and maybe also cropMaxTranspirationPotential = XXX in the .plt files (the value XXX depends on the crop, it usually ranges from -2000 to -18000)

I don't know if the other changes listed in issue #145 will cause problems. If this is the case, we'll need to keep both versions of hisafer available at least until hisafe 4.1 is released.

mariegosme commented 3 years ago

in the meantime, how can the users install the old version of hisafer?

kevinwolz commented 3 years ago

Please provide a reprex

kevinwolz commented 3 years ago

I don’t understand what you mean by “looses” the parameter. None of the template files should have that parameter in the anymore to begin with.

At any rate, previous package versions can always be installed from GitHub via devtools::install_github. If we had a more stable development state, then we could have “releases” of hisafer that coincides with “releases” of Hi-sAFe, but alas we are not at that point yet.