backcompatibility problems with Hi-sAFe 4.0

mariegosme commented 3 years ago

This is an issue to list the functionalities of hisafer that are (temporarily) unavailable during the process of change from HisAFe 4.0 to 4.1. (because hisafer was updated to work with version 4.1 (see #150 and #145) but then we discovered bugs on 4.1 and asked users to keep using 4.0 instead of 4.1):

harmonicWeightedMean is missing from hisafe.par parameter file (see #152 for the workaround)
function hisafe_slice does not work because it is looking for variable phenologicStagevegetative in cells profile (while it was called phenologicStage in version 4.0)
other things might come up as we use hisafer with the old hisafe version...

We are sorry for the inconvenience and we do our best to solve this issue as soon as possible

mariegosme commented 3 years ago

P.S. I tried installing the previous version of hisafer with devtools::install_github("kevinwolz/hisafer@1.4.25") but I got the following error: Error in utils::download.file(url, path, method = method, quiet = quiet, : impossible to open URL 'https://api.github.com/repos/kevinwolz/hisafer/tarball/1.4.25'

kevinwolz commented 3 years ago

@mariegosme you can see all of the changes in #145 that were made in hisafer when Hi-sAFe was upgraded to 4.1.0. In theory, only the removal of input parameters or output variables from Hi-sAFe should cause downstream problems. In this update, those are:

Removal of two input parameters: PLT: cropMaxTranspirationPotential HISAFE.PAR: harmonicWeightedMea

Removal out output vairbale: CELLS: phenologicStage

While there are only three items here, it's not so obvious to know exactly what impacts their removal will have on analyses in hisafer. Thank you for documenting some here, though I'm not really sure what to do with this information. I don't know how else to maintain backwards compatibility other than having users download the old version of hisafer along with the old version Hi-sAFe. I have no idea what it's not working for you to install an old version of hisafer. If you can investigate this and figure it out, I think that would be the best solution to the backwards compatibility issue.

kevinwolz / hisafer

backcompatibility problems with Hi-sAFe 4.0 #153