search

kevinzakka / pytorch-goodies

PyTorch Boilerplate For Research
603 stars 71 forks source link

Update losses.py #9

Closed mfmezger closed 4 years ago

mfmezger commented 4 years ago

I'm not sure I missed anything, but I think it should be logits and not probas. Greetings

kevinzakka commented 4 years ago

Thanks for spotting, I had fixed dice but since I never used jaccard and tversky, forgot to update them as well.

mfmezger commented 4 years ago

I think the cast is necessary, but i am not sure. I will check that tomorrow. But i think the cast could fix the problem of Issue #6 .

mfmezger commented 4 years ago

Hi, so i checked it again, for my data its only working when i add the cast. Is this for your data not the case?

mfmezger commented 4 years ago

I removed the casts.

kevinzakka commented 4 years ago

Thanks @mfmezger!