Closed lk77 closed 3 years ago
That's fair, I'll move react-native
to optional.
thanks !
react-native
is now an optionalDependency
in 2.3.7
Thanks for reporting!
Unfortunately, the default for npm install
is to include optionalDependencies
by default. This causes anyone not using react-native
to install it by default. Unfortunately, I don't think that's worth the cost of fixing the warning, so I'll be reverting the change.
Arf, ok nevermind
I believe my issue was misleading, sorry,
it's seems that the warning is caused by this optional dependency : @unimodules/react-native-adapter
you could try to do something like that :
"peerDependencies": {
"@unimodules/react-native-adapter": "*",
},
"peerDependenciesMeta": {
"@unimodules/react-native-adapter": {
"optional": true
}
}
i think npm will not install it and will not warn the end user about it
i made a fork : https://github.com/lk77/isomorphic-webcrypto and it seems to work
Hello,
we have a warning related to react-native in dev
https://github.com/kevlened/isomorphic-webcrypto/blob/734d23cf628c07a265366725d91e04aa9089fc7f/package.json#L66
we are using vue with pubnub, why those dependencies are in dev and not in optional ?
For what i understand you need it in your tests, so you could install it in your test scripts, like in the .travis.yml file with a :
thanks