search

kevlened / isomorphic-webcrypto

:game_die: webcrypto library for Node, React Native and IE11+
https://www.w3.org/TR/WebCryptoAPI/
MIT License
116 stars 43 forks source link

Large react-native library being pulled in from indirect dependencies #40

Closed spilliton closed 3 years ago

spilliton commented 3 years ago

We noticed our app deploy size jump significantly in the past 2 hours and it appears to be related to the recent change in this library. Here was npm ls react-native before:

└── (empty)

Now (without any changes on our end) 

  └─┬ ringcentral@3.2.1
    └─┬ pubnub@4.29.11
      └─┬ isomorphic-webcrypto@2.3.7
        └── react-native@0.61.5
kevlened commented 3 years ago

Do you install all optionalDependencies by default? react-native was moved to the optionalDependencies.

kevlened commented 3 years ago

It seems this happens by default. Moving it to optionalDependencies was a mistake. Reverting.

kevlened commented 3 years ago

This is fixed in 2.3.8. Apologies for the inconvenience.

lk77 commented 3 years ago

Sorry for the inconvenience, i tought that optional dependencies were not installed by default, which is not the case