search

kevlened / pytest-parallel

A pytest plugin for parallel and concurrent testing
https://github.com/browsertron/pytest-parallel/issues/104#issuecomment-1293941066
MIT License
313 stars 59 forks source link

Added mark for sequenced execution. Fixes #80 #107

Open norraxx opened 2 years ago

norraxx commented 2 years ago

Added option to mark tests, that shouldn't be executed in parallel mode.

Via: https://github.com/browsertron/pytest-parallel/issues/80

alfredo-f commented 2 years ago

I love this!

How were you able to test this new feature?

norraxx commented 2 years ago

I've downloaded the project, checkout the branch, builded it, installed it, runned tests.

alfredo-f commented 2 years ago

I noticed #92 by @svetlyak40wt implemented a similar feature, and the unit test 

tests/test_no_parallel.py

was added. Have you done something similar?

norraxx commented 2 years ago

Oh I see what you're asking for. Nope :-) There is no any test for this feature. Should I add it?

alfredo-f commented 2 years ago

Well it would be a huge plus if you could demonstrate that the feature actually works 🚀

norraxx commented 2 years ago

Ok, but you'll have to wait, give me some time for it. :-)

norraxx commented 2 years ago

First of all, tests as they are in the repository are not working on python3.8.

  1. class ThreadLocalFixtureDef is fighting with pytest tmp_path_factory fixture, during the the fixture intialization phase. https://github.com/pytest-dev/pytest/blob/main/src/_pytest/fixtures.py#L1036. If I comment the line, tests will run.
  2. test_pytest_html and test_collection_collect_only are broken

Added the simple test.

norraxx commented 2 years ago

@alfredo-f ping

alfredo-f commented 2 years ago

Lgtm

norraxx commented 2 years ago

@kevlened Is this reporistory is not maintained anymore?