search

kevlened / pytest-parallel

A pytest plugin for parallel and concurrent testing
https://github.com/browsertron/pytest-parallel/issues/104#issuecomment-1293941066
MIT License
313 stars 59 forks source link

Update the environ shim to be compatible with Python 3.9 #98

Closed andni233 closed 3 years ago

andni233 commented 3 years ago

The os.putenv() and os.unsetenv() are always available starting in Python 3.9, removing the need for special handling in the os._Environ mapping: https://github.com/python/cpython/commit/b8d1262e8afe7b907b4a394a191739571092acdb

To get the tests in working order I had to limit them to run with pytest<6.0. I have not investigated why the tests can not run with more recent pytest versions.

To my knowledge this is the only outstanding issue for Python 3.9 support. Fixes #89

codecov-commenter commented 3 years ago

Codecov Report

Merging #98 (448a404) into master (388e194) will decrease coverage by 1.07%. The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   85.25%   84.17%   -1.08%     
==========================================
  Files           4        4              
  Lines         312      316       +4     
  Branches       30       31       +1     
==========================================
  Hits          266      266              
- Misses         36       39       +3     
- Partials       10       11       +1
Flag Coverage Δ
linux 84.17% <20.00%> (-1.08%) :arrow_down:
py36 83.66% <20.00%> (-1.11%) :arrow_down:
py37 83.66% <20.00%> (-1.11%) :arrow_down:
py38 84.07% <20.00%> (-1.09%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_general.py 100.00% <ø> (ø)
pytest_parallel/__init__.py 77.97% <20.00%> (-1.40%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 388e194...448a404. Read the comment docs.

kevlened commented 3 years ago

Apologies for the delay on this

ickc commented 3 years ago

@kevlened, is there anything else blocking for a new release? Thanks.