Open kevnfu opened 8 years ago
Having the list update as the user searches would be rad. If it can't work if we have paging Could we do that for the main search on home? What exactly would happen if we did it with paging? how unsmooth? what about infinite scroll or no paging
If it's a search filtering only whats on the TV List page then the search bar should be on the page itself. Probably under/around All Shows & Watch List buttons. Not the Navigation Bar. I can see a function like that being useful but not vital. Especially if you were able to organize the shows in different ways (by air date/alphabetically/last watched etc.)
Still think the main search bar should be a NavBar constant. You should be able to search from any page you're on and not have to return home
Sorry. I meant infinite scroll when I said paging.
Right now when the page loads it asks the server for data on every user-added series. This will be expensive when someone has alot of shows. So adding infinite scrolling will only load say the first 30 shows.
I thought some more about filtering/sorting and I really need to refactor my code to make doing these things easier. At that point maybe I can quickly try a few different implementations and we can decide what works and what doesn't.
I don't agree that there should be another, separate search bar when one is so closely related to the other. Your version of the navbar search is to be able to add new shows. My version is simply first searching the shows already added, then searching all other shows.
What if the show they're searching for is already in their list? What does your version do in that case?
Implemented search in the navbar to filter out series on the page.
Search now searches tmdb for shows (and allows adding to watchlist) if user presses enter or the search icon.
Instead of filtering, changed it to scrolling. Things to adjust:
Paintgoo said:
This is what I'm thinking:
I thought about having the list update as the user types, and not only after the user presses enter, but w/ paging it might not be a smooth experience.