Closed kevquirk closed 8 months ago
garritfra
commented
8 months ago Observation: Could be linked to this Dependabot PR I recently merged: https://github.com/kevquirk/512kb.club/pull/1420
Some people claim that this error surfaced after a ruby update. The release notes in that PR say something about a bump of the ruby version. I'll try to somehow revert it on my phone to see if that fixes it.
garritfra
commented
8 months ago Nope, no luck. 😕 CI is still failing on that revert PR.
kevquirk
commented
8 months ago Yeah, I bumped ruby to 3.1.3 locally to see if I could get builds working, but it's still failing. I haven't had time to investigate further.
zwbetz-gh
commented
8 months ago This was an interesting one to track down 😅 .
First, I was able to reproduce it locally with this Dockerfile:
FROM ruby:3.3.0-bookworm
WORKDIR /usr/src/app
COPY Gemfile Gemfile.lock ./
RUN bundle update --bundler
RUN bundle install
COPY . .
RUN ruby --version \
&& bundle --version \
&& jekyll --version
EXPOSE 4000
CMD [ "bundle", "exec", "jekyll", "serve", "--host", "0.0.0.0" ]
# To hit local server, go to http://127.0.0.1:4000/And these shell commands:
docker build \
--progress plain \
-t "512kb-club" \
.
docker run \
--rm \
-p "4000:4000" \
--name "512kb-club" \
"512kb-club"After some googling, this stack overflow answer was the only hint I found.
I searched the codebase for YAML.load_file and turns out that _plugins/rss_feed.rb was using it.
The fix was to change this line:
To be:
websites = YAML.load_file(
File.join(site.source, '_data', 'sites.yml'),
permitted_classes: [Date]
)Wow! Thanks for hunting this one down. Do you have a minute to open a PR? I'm currently at the airport without a proper computing device. 😅
Otherwise I (or @kevquirk?) can do it later. Thanks again @zwbetz-gh!
kevquirk
commented
8 months ago That worked a treat. Thanks @zwbetz-gh 🎉
zwbetz-gh
commented
8 months ago Nice! Thank y'all for this cool project 👍
Don't have time to troubleshoot this at the moment. Will look when I get time. Here's the Vercel build log: